From 6c2cc1b70699c6e868369a3d1213b0ccc1c30cd5 Mon Sep 17 00:00:00 2001 From: Juan RP Date: Mon, 24 Mar 2014 11:15:29 +0100 Subject: [PATCH] hooks/post-install/99-pkglint: add checks for missing shlibs and SONAME bumps. Created by Gottox and minor fixes by myself. --- common/hooks/post-install/99-pkglint.sh | 34 ++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/common/hooks/post-install/99-pkglint.sh b/common/hooks/post-install/99-pkglint.sh index bee6a90eeb2..2d41e1cd844 100644 --- a/common/hooks/post-install/99-pkglint.sh +++ b/common/hooks/post-install/99-pkglint.sh @@ -1,7 +1,8 @@ # This hook checks for common issues related to void. hook() { - local error=0 + local error=0 filename= rev= libname= conflictPkg= conflictFile= + conflictRev= found= mapshlibs=$XBPS_COMMONDIR/shlibs for f in bin sbin lib lib32; do if [ -d ${PKGDESTDIR}/${f} ]; then @@ -18,4 +19,35 @@ hook() { if [ $error -gt 0 ]; then msg_error "${pkgver}: cannot continue with installation!\n" fi + + # Check for missing shlibs and SONAME bumps. + if [ ! -f "${PKGDESTDIR}/shlib-provides" ]; then + return 0 + fi + + for filename in `cat ${PKGDESTDIR}/shlib-provides`; do + rev=${filename#*.so.} + libname=${filename%.so*} + grep -E "^${libname}\.so[\.0-9.]*[[:blank:]]+${pkgname}-[^-]+_[0-9]+$" $mapshlibs | { \ + while read conflictFile conflictPkg; do + found=1 + conflictRev=${conflictFile#*.so.} + if [ "$rev" = "$conflictRev" ]; then + continue + elif [[ "$rev".* =~ "$conflictRev" ]]; then + continue + fi + msg_red "${pkgver}: SONAME bump detected: ${libname}.so.${conflictRev} -> ${libname}.so.${rev}\n" + msg_red "${pkgver}: please update common/shlibs with this line: \"${libname}.so.${rev} ${pkgver}\"\n" + msg_red "${pkgver}: all reverse dependencies should also be revbumped to be rebuilt against ${libname}.so.${rev}:\n" + for x in $($XBPS_QUERY_XCMD -RX ${pkgname}); do + msg_red " ${x}\n" + done + msg_error "${pkgver}: cannot continue with installation!\n" + done + if [ -z "$found" ]; then + msg_error "${pkgver}: ${libname}.so.${rev} not found in common/shlibs. Please add it.\n" + fi; + } + done }