From 7c4f20ba89bee94b5259df3b0b1af0bb1deeab0a Mon Sep 17 00:00:00 2001 From: Juan RP Date: Tue, 26 Mar 2013 10:35:20 +0100 Subject: [PATCH] lib/transaction_commit.c: fix a use-after-free in state cb (found by ojab). --- lib/transaction_commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/transaction_commit.c b/lib/transaction_commit.c index dd148b0..e1edf7b 100644 --- lib/transaction_commit.c +++ lib/transaction_commit.c @@ -88,11 +88,11 @@ check_binpkgs_hash(struct xbps_handle *xhp, prop_object_iterator_t iter) rv = xbps_file_hash_check(binfile, sha256); if (rv != 0) { free(binfile); - free(filen); xbps_set_cb_state(xhp, XBPS_STATE_VERIFY_FAIL, rv, pkgver, "Failed to verify `%s' package integrity: %s", filen, strerror(rv)); + free(filen); break; } free(binfile); -- 1.8.2