tastytea/libravatarserv
1
0
Fork 1
Code Issues Pull Requests Releases 20 Wiki Activity

Add support for the default (d) parameter #2

New Issue
Closed
opened 2018-11-25 10:52:59 +01:00 by tastytea · 2 comments
tastytea commented 2018-11-25 10:52:59 +01:00
Owner
Copy Link

This parameter controls what happens if an image is missing.

We should at least support:

  • d=404: Return a 404 error
  • d=mm, d=mp: "Mystery man" or "Mystery person", static file

The documentation also mentions the possibility to supply a fallback URL. I don't think we should download remote images, but maybe return a redirect?

This parameter controls what happens if an image is missing. We should at least support: * `d=404`: Return a 404 error * `d=mm`, `d=mp`: "Mystery man" or "Mystery person", static file The [documentation](https://wiki.libravatar.org/api/) also mentions the possibility to supply a fallback URL. I don't think we should download remote images, but maybe return a redirect?
tastytea added the
enhancement
 label 2018-11-25 10:53:05 +01:00
tastytea commented 2018-11-26 05:13:15 +01:00
Author
Owner
Copy Link

404 is implemented. Fallback URL is implemented by sending a redirect (HTTP 307).

`404` is implemented. Fallback URL is implemented by sending a redirect (HTTP 307).
tastytea commented 2018-11-27 04:57:31 +01:00
Author
Owner
Copy Link

mp/mm is implemented. We should implement identicon too, because it is used quite often.

`mp`/`mm` is implemented. We should implement identicon too, because it is used quite often.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Assignees
Clear assignees
tastytea
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tastytea/libravatarserv#2
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?