Do not reopen stdout while image resizing #7

mymedia2 · 2020-10-24T08:16:43+02:00

mymedia2 commented

2020-10-24 08:16:43 +02:00

On Linux, some web-servers (Apache in particular) close file with fd = 1 and offer something else as stdout. Notable difference can be seen with a pipe and an immediate redirection. Consider:

$ REQUEST_URI=/avatar/68b329da9893e34099c7d8ad5cb9c940 libravatarserv | cat > /tmp/response1.out
$ REQUEST_URI=/avatar/68b329da9893e34099c7d8ad5cb9c940 libravatarserv > /tmp/response2.out
$ diff -s /tmp/response{1,2}.out
Binary files /tmp/response1.out and /tmp/response2.out differ

Solution.

The output should be identical in both cases. So do not let ImageMagick to open /dev/stdout by itself, instead write the resulted image to an in-memory buffer and then to a file associated with the "cout" global object.

Fixes: #6

On Linux, some web-servers (Apache in particular) close file with fd = 1 and offer something else as stdout. Notable difference can be seen with a pipe and an immediate redirection. Consider: $ REQUEST_URI=/avatar/68b329da9893e34099c7d8ad5cb9c940 libravatarserv | cat > /tmp/response1.out $ REQUEST_URI=/avatar/68b329da9893e34099c7d8ad5cb9c940 libravatarserv > /tmp/response2.out $ diff -s /tmp/response{1,2}.out Binary files /tmp/response1.out and /tmp/response2.out differ Solution. The output should be identical in both cases. So do not let ImageMagick to open /dev/stdout by itself, instead write the resulted image to an in-memory buffer and then to a file associated with the "cout" global object. Fixes: #6

tastytea referenced this issue from a commit

2020-10-24 08:41:14 +02:00

Merge pull request 'Do not reopen stdout while image resizing' (#7) from mymedia2/libravatarserv:patch-1 into master Reviewed-on: https://schlomp.space/tastytea/libravatarserv/pulls/7

tastytea merged commit 53466aadef into master

2020-10-24 08:41:14 +02:00

tastytea commented

2020-10-24 08:41:25 +02:00

Thanks!

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: tastytea/libravatarserv#7