tastytea
/
remwharead
1
0
Fork 0
Code Issues 1 Pull Requests Releases 37 Activity

Fix/supress clang-tidy warnings in Mozilla-wrapper.

This commit is contained in:
tastytea 2019-10-30 07:47:39 +01:00
parent e8f0156296
commit a5ec7609f9
Signed by: tastytea
GPG Key ID: CFC39497F1B26E07
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
browser-plugins/webextension/native-wrapper/remwharead_wrapper.cpp
View File

@ -27,7 +27,11 @@ using std::cout;
using std::uint32_t; using std::uint32_t;
using std::system; using std::system;
const string read_input() string read_input();
void send_message(const string &message);
int launch(const string &args);
string read_input()
{ {
// Read message length. // Read message length.
uint32_t length; uint32_t length;
@ -55,7 +59,8 @@ const string read_input()
void send_message(const string &message) void send_message(const string &message)
{ {
const uint32_t length = static_cast<uint32_t>(message.length() + 2); const auto length = static_cast<uint32_t>(message.length() + 2);
// NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast) - Necessary.
cout.write(reinterpret_cast<const char*>(&length), sizeof(uint32_t)); cout.write(reinterpret_cast<const char*>(&length), sizeof(uint32_t));
cout << '"' << message << '"'; cout << '"' << message << '"';
} }
@ -63,10 +68,11 @@ void send_message(const string &message)
int launch(const string &args) int launch(const string &args)
{ {
const string cmd = "remwharead " + args + " 2>/dev/null"; const string cmd = "remwharead " + args + " 2>/dev/null";
// NOLINTNEXTLINE(cert-env33-c) - We get the arguments in a string.
int ret = system(cmd.c_str()); int ret = system(cmd.c_str());
if (WIFEXITED(ret)) if (WIFEXITED(ret)) // NOLINT(hicpp-signed-bitwise) - Necessary.
{ {
ret = WEXITSTATUS(ret); ret = WEXITSTATUS(ret); // NOLINT(hicpp-signed-bitwise) - Necessary.
} }
return ret; return ret;